COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

remove `_pd_block_diffractogram.diffractogram_id` and `_pd_phase_block.phase_id` #137

Closed rowlesmr closed 1 year ago

rowlesmr commented 1 year ago

When we made PD_PHASE a Set caetgory, and PD_BLOCK a Loop category, we moved things around and we also added _pd_phase.id and _pd_diffractogram.id as the principle methods of identifying phases and patterns.

As in the old way, we could loop block IDs, we wanted to keep that same possibility, so we added _pd_block_diffractogram.diffractogram_id and _pd_phase_block.phase_id to keep that ability, however that requirement has been subsumed by individual phase and diffractogram_id tags in different categories.

Also, it conflates the block id methodology with the phase and diffractogram.id methodology of identifying things.

Straight up deletion, as they're new and not in any other previously released dictionary.

See also https://github.com/COMCIFS/Powder_Dictionary/pull/117#issuecomment-1493713618