search

COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

`_pd_meas.detector_id` <-> `_pd_instr_detector.id` #138

Closed rowlesmr closed 1 year ago

rowlesmr commented 1 year ago

From initial discussion here: https://github.com/COMCIFS/Powder_Dictionary/issues/56#issuecomment-1584610839

_pd_meas.detector_id is a data item in PD_MEAS, which is a Loop category keyed on _pd_meas.point_id and _pd_meas.diffractogram_id.

_pd_instr_detector.id is a data item in, and category key of, PD_INSTR_DETECTOR, which is a Loop category.

_pd_meas.detector_id is designed to attribute each point in a diffractogram to the detector whence it came. _pd_instr_detector.id is defined as a link back to _pd_meas.detector_id.

Shouldn't it be the other way around? _pd_meas.detector_id should link back to a _pd_instr_detector.id value?

jamesrhester commented 1 year ago

Agreed.