COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

Use of `List` vs `Array` vs `Matrix` #148

Closed rowlesmr closed 1 year ago

rowlesmr commented 1 year ago

Prompted by discussions https://github.com/COMCIFS/cif_core/pull/399#issuecomment-1587415980 https://github.com/COMCIFS/cif_core/issues/269#issuecomment-1589186767, I had a look at the data items with non-Single container types.

They are:

List

Array

Matrix

I think all of these should be List, as they're just grouping together related values; they're not doing any maths with anything.

_pd_pref_orient_march_dollase.hkl could stay as a Matrix, as _refln.hkl is, too.

Will also need to rename _pd_calc.component_intensity_*_list to remove list from the name; maybe _pd_calc.component_intensities_*.