search

COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

Add mirrors to `pd instr(_detector)` #162

Closed rowlesmr closed 1 year ago

rowlesmr commented 1 year ago

From #157

Add the ability to record mirrors as incident or diffracted optics.

jamesrhester commented 1 year ago

I think that double-tasking the mono and analyser distance data names to be also mirror data names is not going to end well. We (unfortunately) need to have separate mirror data names for these distances.

Although, if we are mapping out optics, it probably is more extensible to have a table of distances together with the object at that distance:

loop_
_order_along_beam
_object_type
_distance_from_source
1 mirror              10
2 mono                15
3 collimator         20
4 sample              25
5 analyser           30
6 detector            35

_pd_instr_mirror can then reference _order_along_beam to locate the mirror it is describing.

rowlesmr commented 1 year ago

is not going to end well

I sense prior experience in this statement.

.

I'll have a think. Will require rejigging PD_INSTR and PD_INSTR_DETECTOR.

rowlesmr commented 1 year ago

Commentry moved to https://github.com/COMCIFS/Powder_Dictionary/issues/157#issuecomment-1614126317

rowlesmr commented 1 year ago

Good ideas in #157, no time atm to implement them.

Will probably need to carve off into a separate dictionary.