COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

Several data items are no longer allowed to have s.u. values #37

Closed vaitkus closed 1 year ago

vaitkus commented 1 year ago

Several data items were redefined to no longer allow associated standard uncertainty (s.u.) values when migrating from the DDL1 (version 1.0.1) to the DDLm version of the dictionary. This might have been done on purpose, but I will list these items here just in case since there were similar accidental changes in the CIF_CORE dictionary that had to be resolved. Data items in question:

Should the _type.purpose attribute of any of these be changed from Number to Measurand and in this way allow the associated s.u. values?

briantoby commented 1 year ago

Some of the following are not likely to have a standard uncertainty reported, but I do not see why it should be precluded. They are all experimentally measured quantities or are derived from them.

On Oct 10, 2022, at 8:41 AM, Antanas Vaitkus @.**@.>> wrote:

Several data items were redefined to no longer allow associated standard uncertainty (s.u.) values when migrating from the DDL1 (version 1.0.1) to the DDLm version of the dictionary. This might have been done on purpose, but I will list these items here just in case since there were similar accidental changes in the CIF_CORE dictionary that had to be resolved. Data items in question:

Should the _type.purpose attribute of any of these be changed from Number to Measurand and in this way allow the associated s.u. values?

— Reply to this email directly, view it on GitHubhttps://github.com/COMCIFS/Powder_Dictionary/issues/37, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACH7E2AN6MB6RCVTTDIBLXDWCQMKBANCNFSM6AAAAAARBLRSOY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

rowlesmr commented 1 year ago

.

Some other items that are currently Number that could be Measurand: (with various likelihoods of actually having SUs)

I can start a PR, probably tomorrow.

All _pd_meas.counts_* are excluded from consideration as a Measurand, as their SU is defined to be square root of its value.

jamesrhester commented 1 year ago

I agree that all these should be Measurand. I have a little tool which will add in the su data definitions for all Measurand items so if the PR simply has the Number->Measurand change I can run that tool and update the PR with su definitions.

rowlesmr commented 1 year ago

little tool

Neat! I've dabbled in Julia several years ago, but the compile-every-time-you-run-a-program didn't fit how I used my programs. I should have another look.

jamesrhester commented 1 year ago

Still quite slow because of the compile every time thing, but it is now possible to create a system image that includes your favourite packages already compiled and then it is quite fast.