COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

Fix typos #63

Closed vaitkus closed 1 year ago

vaitkus commented 1 year ago

I tried to be quite conservative with the changes, but please check diligently since in some cases the original intent was not completely clear (e.g. "detectoomator" -> "datector").

rowlesmr commented 1 year ago

"detectoomator" -> "datector"

That reads like someone smooshed together "detector" and "monochromator".

Anyhoo, the last sentence of that description makes no sense to me (the whole thing is below):

Values are the maximum divergence angles in degrees, as limited by Soller slits located between the specimen and the detector in use, and _spec_detc is used in place of _spec_anal and *_anal_detc if there is no analyser in use.

Ah, the same sentence is present in _pd_instr.soller_eq_spec_detc, _pd_instr.soller_eq_spec_anal, and _pd_instr.soller_eq_anal_detc, and all three use different punctuation, along with a little copy pasta, to rotate through the same type of warning/description.

Having a go at doing a fix. .

the entire save frame:

save_pd_instr.soller_eq_spec_detc

    _definition.id                '_pd_instr.soller_eq_spec_detc'
    _alias.definition_id          '_pd_instr_soller_eq_spec/detc'
    _definition.update            2023-01-06
    _description.text
;
    Describes collimation in the equatorial plane (the plane
    containing the incident and diffracted beams) for the
    instrument. Values are the maximum divergence angles in degrees,
    as limited by Soller slits located between the specimen and the
    detector in use, and *_spec_detc is used in place of
    *_spec_anal and *_anal_detc if there is no analyser in use.
;
    _name.category_id             pd_instr_detector
    _name.object_id               soller_eq_spec_detc
    _type.purpose                 Number
    _type.source                  Derived
    _type.container               Single
    _type.contents                Real
    _enumeration.range            0.0:
    _units.code                   degrees

save_
rowlesmr commented 1 year ago

Old:

Describes collimation in the equatorial plane (the plane containing the incident and diffracted beams) for the instrument. Values are the maximum divergence angles in degrees, as limited by Soller slits located between the specimen and the detectoomator in use, and _spec_detc is used in place of _spec_anal and *_anal_detc if there is no analyser in use.

New:

Describes collimation in the equatorial plane (the plane containing the incident and diffracted beams) for the instrument. Values are the maximum divergence angles in degrees, as limited by Soller slits located between the specimen and the detector in use. Note that _spec_detc is used in place of _spec_anal and *_anal_detc if there is no analyser in use.