search

COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

_pd_calibration.conversion_eqn: potentially outdated description #99

Closed vaitkus closed 1 year ago

vaitkus commented 1 year ago

Among other things, the definition of the _pd_calibration.conversion_eqn data item claims that:

    Use _pd_calib_std.external_* to define a pointer
    to the file or data block containing the data used to
    determine the parameter values in this function.

However, the only _pd_calib_std.external_* data items that are currently defined in the dictionary are _pd_calib_std.external_block_id and _pd_calib_std.external_name which seemingly do not allow to specify an external file, only an external data block.

rowlesmr commented 1 year ago

Probably because of this in cif_pd.dic:

1997-10-29 Changed _pd_calib_std_external_id to _pd_calib_std_external_block_id.

The dictionary was released the same day.

jamesrhester commented 1 year ago

Definitely we should drop all references to "files".