COMCIFS / cif_core

The IUCr CIF core dictionary
14 stars 9 forks source link

cif_core.dic: add the `_exptl_absorpt_special_details` data item #234

Closed vaitkus closed 1 year ago

vaitkus commented 2 years ago

In the 267887 revision of the COD there are over 1000 files that contain the _exptl_absorpt_special_details data item, although, no such item is defined in the CIF_CORE dictionary.

My initial assumption was that this data item was simply used instead of the properly defined _exptl_absorpt_process_details data item. However, some additional analysis revealed that in ~800 cases out of the 1000, both the _exptl_absorpt_special_details and the _exptl_absorpt_process_details data items are defined and often with differing values. For example, COD entry 7060029 [1] contains the following data item values:

<i>SADABS</i> (Krause et al., 2015)

I am unsure where the _exptl_absorpt_special_details tag originated from, however, I have noticed that all of the affected files seem to be generated by SHELXL. What is more, I found some SHELX-related material online [2] that provides a usage example of the _exptl_absorpt_special_details data item (see slide "Comments on sample absorption correction").

[1] http://www.crystallography.net/cod/7060029.cif@258905 [2] https://chemistry.harvard.edu/files/chemistry/files/tutorial_using_shelx_for_neutrons.pdf

jamesrhester commented 2 years ago

I will pass this to the core DMG as clearly this is a data name that is useful, as shown by your ref [2].

jamesrhester commented 2 years ago

The core DMG support the addition of this data name to the dictionary. Given its origin, we will need to include the all underscore version as an alias.

vaitkus commented 1 year ago

Issue resolved by merging PR #234. Thanks, @rowlesmr.