search

COMCIFS / cif_core

The IUCr CIF core dictionary
15 stars 9 forks source link

_type.source of many other SU items changed from `Related` #433

Closed rowlesmr closed 1 year ago

rowlesmr commented 1 year ago

Split from #431

A bunch of SU data items' _type.source was Related, which doesn't seem to link up with the description of Related, so I changed them all to match the _type.source of the data item to which the SU belongs.

vaitkus commented 1 year ago

@jamesrhester , do you have any insights on the topic? Should the SU items have the Related purpose or should the inherit it from the measurand item?

jamesrhester commented 1 year ago

_type.source is Related because the su items are _name.linked_item_id to the dataname they are the SU of, so therefore they are Related to that data name. This makes sense to me, but I note this use of Related is not described explicitly.

rowlesmr commented 1 year ago

This also means that every other SU item I didn't touch is wrong, as well as the general_su save frame in templ_attr.cif.

jamesrhester commented 1 year ago

I've decided that I think _type.source of "same as linked data name" is appropriate (as this PR suggests). It's not a strong opinion, as in any case the information provided is redundant.

jamesrhester commented 1 year ago

Rejecting as per discussion in #434