search

COMCIFS / cif_core

The IUCr CIF core dictionary
15 stars 9 forks source link

Describe primitive data items #438

Closed vaitkus closed 1 year ago

vaitkus commented 1 year ago

This PR rewords some of the definitions as discussed in #437.

Specifically, it properly defines the primitive and non-primitive data items, and explicitly specifies that Definition methods should not be used on primitive items.

I was not sure if Related items should be considered primitive or non-primitive. I guess they should be handled in the same way ass Assigned values (primitive/non-primitive depending on the context).

jamesrhester commented 1 year ago

I think related items if they are links between categories are just assigned, but if they are SUs then they could be anything. So the primitive/non-primitive distinction doesn't apply neatly.

vaitkus commented 1 year ago

I think related items if they are links between categories are just assigned, but if they are SUs then they could be anything. So the primitive/non-primitive distinction doesn't apply neatly.

Ok, we can update the Related description to explicitly state that. This can probably be done in the same PR in which we clarify that the Related state also applies to SU items (see #434).