Rename the 'photons per second' unit to 'photons_per_second'

COMCIFS / cif_core

The IUCr CIF core dictionary

14 stars 9 forks source link

Rename the 'photons per second' unit to 'photons_per_second' #472

Closed vaitkus closed 5 months ago

vaitkus commented 7 months ago

Closes #303.

The 'photons per second' units were renamed to 'photons_per_second' in the upcoming version 1.8.8 of the cif_img.dic dictionary [1] so the same change can be reflected in DDLm as well.

Although it is unlikely that the units will change again, we might want to wait until the release of version 1.8.8 just to be safe before merging this PR.

[1] https://github.com/yayahjb/cbf_imgcif_dictionary/tree/main

jamesrhester commented 5 months ago

As the first official DDLm version of cif_img will be based on 1.8.8, I think it makes sense for this change to be in place prior to that version being generated.