search

COMCIFS / magnetic_dic

Development of the magnetic CIF dictionary
0 stars 4 forks source link

Can we use proper DDLm matrices for the transformations? #18

Closed jamesrhester closed 8 years ago

jamesrhester commented 8 years ago

The transform_Pp_abc datanames could be represented as proper DDLm matrices

jamesrhester commented 8 years ago

Definitions added of form 'transform_P'. Fully fleshed out _space_group.magn_transform_BNS_P for Branton to vet.

brantonc commented 8 years ago

Consider 'transform_Pp_mat' instead. The small 'p' is needed since the origin shift is included in the matrix, and the 'mat' is needed to differentiate the name from 'abc'.

brantonc commented 8 years ago

As I look at the structure of the dictionary and the new Matrix quantities that have been added recently, it makes good sense to leave off the 'mat' from the names.

jamesrhester commented 8 years ago

OK, I will update the dictionary to remove 'Mat' - I agree that it is unnecessary.