COMCIFS / magnetic_dic

Development of the magnetic CIF dictionary
0 stars 4 forks source link

transformloop descriptions should be just free text, not fixed strings #19

Closed jamesrhester closed 8 years ago

jamesrhester commented 8 years ago

The descriptions seem to want to be both fixed strings, and free text. Suggest fixing the possible strings, and other tabulations can then be added to the dictionary as they become available.

jamesrhester commented 8 years ago

Created _space_group_magn_ssg_transforms.source with enumerated strings, although Branton suggests only free text is reasonable.

brantonc commented 8 years ago

That's fine so long as free text is possible for undefined settings such as literature references. This should be done in parallel for both the the _space_group_magn_transforms and _space_group_magn_ssg_transforms categories.

jamesrhester commented 8 years ago

Added "source" enumerated types for _space_group_magn_transforms as well, and adjusted definitions accordingly.