search

COMCIFS / magnetic_dic

Development of the magnetic CIF dictionary
0 stars 4 forks source link

Remove several _definition.update attributes to resolve import issues. #32

Closed vaitkus closed 1 year ago

vaitkus commented 1 year ago

Both the importing definition and the imported save frame contains the _definition.update attribute. This is not allowed under the default import behaviour (exit on duplicate). Removing this attribute from the dictionary definitions is one way of solving this issue, but a different approach might also be suitable (e.g. replace on import, ignore on import).

jamesrhester commented 1 year ago

I think with templates it's important to fail if there are any conflicts between the template and definition, as the correct choice is not always obvious. On the other hand, if a template has been updated that seems like useful information to preserve. However, as the update is still preserved in the git history, I think it is OK to remove dates from templates. The date that the main definition was updated is more important.