search

COMCIFS / magnetic_dic

Development of the magnetic CIF dictionary
0 stars 4 forks source link

Add automated style check #43

Closed jamesrhester closed 11 months ago

jamesrhester commented 11 months ago

The magnetic dictionary should meet style guidelines before the latest round of changes comes through.

vaitkus commented 11 months ago

I have some more technical issues to report/PR, but I guess it would be better to wait until you merge this PR?

jamesrhester commented 11 months ago

This PR can be treated as orthogonal to the other ones. We can just ignore the red crosses on PRs until the PR for the properly-formatted version comes through. I've found a few deficiencies in my linter and pretty-printer related to missing category definitions (i.e. the definitions are in imported dictionaries) that is delaying me providing this PR, but once I've fixed those I'll accept any outstanding technical PRs first, then pretty-print and immediately submit a PR for the proper layout.

vaitkus commented 11 months ago

Great, thank you for clarifying.