Closed vaitkus closed 7 months ago
I'm going to guess that existing code has not taken advantage of the freedom offered by the "Text" type and so we can restrict to "Word" type. I would prefer that we bundle these small changes into an email that @brantonc can send to the relevant software authors to double-check that they have no issues.
Ok, so this particular change can be summarised as:
The following identifier data items would no longer be allowed to have ASCII whitespaces in their values:
I support this change. I'm not aware of any software authors for whom this would be a problem.
This PR updates id definitions so they match those in the
CIF_CORE
dictionary.Note, that in some cases the assigned source values differ from the default ones, therefore this might conflict with PR https://github.com/COMCIFS/magnetic_dic/pull/46.