search

COMCIFS / magnetic_dic

Development of the magnetic CIF dictionary
0 stars 4 forks source link

Add the 'none' measurement unit to all numeric items without explicit units #65

Closed vaitkus closed 7 months ago

vaitkus commented 7 months ago

This PR adds the none measurement unit to all numeric items without explicit units. To my understanding this looks reasonable, however, please double check this before merging.

Also, I did not assign units to the _parent_space_group.child_transform_pp_abc and _parent_space_group.transform_pp_abc as these are probably not numeric (see https://github.com/COMCIFS/magnetic_dic/pull/64).

brantonc commented 7 months ago

You are correct. The *_transform_Pp_abc items are not numeric.

From: Antanas Vaitkus @.> Sent: Friday, January 19, 2024 9:24 AM To: COMCIFS/magnetic_dic @.> Cc: Subscribed @.***> Subject: [COMCIFS/magnetic_dic] Add the 'none' measurement unit to all numeric items without explicit units (PR #65)

This PR adds the none measurement unit to all numeric items without explicit units. To my understanding this looks reasonable, however, please double check this before merging.

Also, I did not assign units to the _parent_space_group.child_transform_pp_abc and _parent_space_group.transform_pp_abc as these are probably not numeric (see #64https://github.com/COMCIFS/magnetic_dic/pull/64).

You can view, comment on, or merge this pull request online at:

https://github.com/COMCIFS/magnetic_dic/pull/65

Commit Summary

File Changes

(1 filehttps://github.com/COMCIFS/magnetic_dic/pull/65/files)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://github.com/COMCIFS/magnetic_dic/pull/65, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACZAIQTAKDQICAOL4JYX6XLYPKM2PAVCNFSM6AAAAABCCGNH7CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TAOBXG43TQNA. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

vaitkus commented 7 months ago

Thank you for the review, I will merge it then as is.