COMOKIT / COMOKIT-Model

A GAMA (http://gama-platform.org) model on the assessment and comparisons of intervention policies against the CoVid19 pandemics
https://comokit.org
GNU General Public License v3.0
25 stars 18 forks source link

Running batch experiment from ReplicationsSensitivity.gaml with facet keep_simulations to false raise exception at init #31

Closed chapuisk closed 4 years ago

chapuisk commented 4 years ago

The batch simulations run smoothly, but as soon as keep_simulations facet is set to false, it raises an exception. It seems that experiment agent try to access variables from the simulation agent (see init {} block in Abstract batch experiment.gaml) :

1 occurence in Sensitivity0 at cycle 0: This experiment does not keep its simulations. DEFAULT_DATASETS_FOLDER_NAME cannot be retrieved in this context in string build_dataset_path (string _datasets_folder_path <- project_path + DEFAULT_DATASETS_FOLDER_NAME, string _case_study_folder_name <- DEFAULT_CASE_STUDY_FOLDER_NAME)

Somehow related to a closed issue in Gama : https://github.com/gama-platform/gama/issues/2727

AlexisDrogoul commented 4 years ago

Well, this seems quite normal: DEFAULT_DATASETS_FOLDER_NAME is defined in the model/simulation and cannot be accessed by the experiment. I have however relaxed the constraints a little bit for the constants. I will commit soon.

AlexisDrogoul commented 4 years ago

Should be fixed (at least for constants) in https://github.com/gama-platform/gama/commit/ac17bc33241004169238942449757dcc82661f91

chapuisk commented 4 years ago

We are still not able to launch batch with facet keep_simulation: false ! It might requires to move all path management in experiments.

AlexisDrogoul commented 4 years ago

Have you checked if you are running the latest version ?

AlexisDrogoul commented 4 years ago

I've pushed another fix for the special case of constants, it should be ok now.