Review REQUESTED – L1 DOC TMP Porewater

amyerspigg commented 2 months ago

@stephpenn1 could you please review these "L1" DOC files and let me know if they are at the correct processing level before I put them on Google Drive?

https://github.com/COMPASS-DOE/TEMPEST_Porewater/tree/main/processing_scripts/DOC/TEMPORARY

stephpenn1 commented 2 months ago

Yes sure, when do you need this reviewed by?

amyerspigg commented 1 month ago

@stephpenn1 didn't see your reply! Does in the next two weeks work? I also have the CDOM data ready to review now too. https://github.com/COMPASS-DOE/TEMPEST_Porewater/tree/main/processing_scripts/CDOM/TEMPORARY

Once you review and approved, I'll put in the google drive :)

stephpenn1 commented 1 month ago

Hi! Your datasets look great, I just have a few questions and suggestions:

I noticed there aren't any flags, were there any that were applied?
In your plot column, I think we are using Saltwater but we'll need confirmation on this (I'll check)
My preference for theEvent column would be to change it to site (and lowercase to match the other columns)
Any date columns like evacuation_date collection_datetime and tz should be on the left side of the datasets with the other metadata columns
I like the standardization of the filenames :-) although they're a little bit inconsistent; for example, instead using TMP_PW_GRIDS_NPOC_TDN_2022_L1.csv and TMP_PW_GRIDS_POOL_Indicies_CDOM_2022_L1.csv so that they go _SITE_SAMPLETYPE_ORG_ANALYSISTYPE_YEARLEVEL.csv thoughts?

Also, let me know if I am not reviewing these datasets in the way you intended

COMPASS-DOE / TEMPEST_Porewater

Review REQUESTED – L1 DOC TMP Porewater #2