Open bpbond opened 2 weeks ago
Ran devtools::check(remote = TRUE, manual = TRUE) - We have one note about DOIs I think
R CMD check results ─────────────────────────────────────────────────────── fluxfinder 0.1.0 ──── Duration: 2m 4.9s
❯ checking CRAN incoming feasibility ... [78s] NOTE Maintainer: 'Stephanie Wilson wilsonsj@si.edu'
New submission
Found the following URLs which should use \doi (with the DOI name only): File 'ffi_fit_models.Rd': http://dx.doi.org/10.1016/j.soilbio.2003.07.005 http://dx.doi.org/10.2136/sssaj1981.03615995004500020017x File 'ffi_hm1981.Rd': http://dx.doi.org/10.2136/sssaj1981.03615995004500020017x File 'ideal-gas-law.Rd': http://dx.doi.org/10.1016/S0168-1923(02)00023-0
0 errors ✔ | 0 warnings ✔ | 1 note ✖
OK! Thanks. Do you know how to fix?
Here's an example: https://github.com/dankelley/oce/issues/1770#issuecomment-754615072
Thank you for the example - I am going to try... make a new branch, edit the doi's, then pushing up back up to Github
New branch Edit DOIs Rebuild the documentation Commit and push
Okay - let's see how I did. I requested your review.
@bpbond edit: #80
After DOI fixes... reran and only note is that this is a new submission so check!
── R CMD check results ─────────────────────────────────────────────────────── fluxfinder 0.1.0 ──── Duration: 2m 1.5s
❯ checking CRAN incoming feasibility ... [76s] NOTE Maintainer: 'Stephanie Wilson wilsonsj@si.edu'
New submission
0 errors ✔ | 0 warnings ✔ | 1 note ✖
Woo hoo!!! 🙌
@bpbond are we good on the pull and push if all the checks went through after my last PR and merge? If so, then I think I can proceed with cran submission steps?
I do! Go ahead with the three steps under "Submit to CRAN"! 🎉
FYI: We got some feedback from CRAN and there are a few things to do then resubmit....
If there are references describing the methods in your package, please
add these in the description field of your DESCRIPTION file in the form
authors (year)
\dontrun{} should only be used if the example really cannot be executed (e.g. because of missing additional software, missing API keys, ...) by the user. That's why wrapping examples in \dontrun{} adds the comment ("# Not run:") as a warning for the user. Does not seem necessary. Please replace \dontrun with \donttest.
Please unwrap the examples if they are executable in < 5 sec, or replace dontrun{} with \donttest{}.
Please fix and resubmit.
Okay! Those seem straightforward. 🤞
First release:
usethis::use_news_md()
usethis::use_cran_comments()
Title:
andDescription:
@return
and@examples
Authors@R:
includes a copyright holder (role 'cph')Prepare for release:
git pull
usethis::use_github_links()
urlchecker::url_check()
devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
git push
Submit to CRAN:
usethis::use_version('major')
devtools::submit_cran()
Wait for CRAN...
usethis::use_github_release()
usethis::use_dev_version(push = TRUE)
usethis::use_news_md()