Merged with metafor.Rmd

COMPASS-DOE / rs-synthesis

0 stars 0 forks source link

Merged with metafor.Rmd #29

Closed stephpenn1 closed 3 years ago

stephpenn1 commented 3 years ago

Do not merge yet until review / discussion w @bpbond

This commit:

adds code from metafor.Rmd
Comments out drainage type code for now
removes duplicated tables and adds interactive capabilities to main summary table
Resolves #23 and closes #27

This commit does not:

resolve potential duplication in the variance data sheet and the srdb variable (the var that originally searched for studies)
address the potential for duplicated code when we apply this to drainage type

bpbond commented 3 years ago

Nice break-test-diagnose-and-fix 👍

For the table summary, it might be more useful and easier to read if different manipulations were spread across columns? We can discuss.

stephpenn1 commented 3 years ago

Oh interesting, let's put that on the agenda for tomorrow

stephpenn1 commented 3 years ago

I will:

[x] Join srdb with google sheet
[x] spread the table summary for readability

stephpenn1 commented 3 years ago

Updated table shows number of studies that include either Rs_annual, Rs_growingseason, or Rh_annual by manipulation in forest ecosystems: (@bpbond)

Screen Shot 2021-04-05 at 6 11 04 PM

bpbond commented 3 years ago

@stephpenn1 The table looks useful—what do you think?

...but also probably wrong. Why are all the numbers identical in the three columns? I would guess the code is counting rows and not non-NA entries, which is what it should.

stephpenn1 commented 3 years ago

Oh you are so right. Brb

It's doing length(unique(Studies))