search

CON-In-A-Box / CIAB-Portal

The Core of Con-In-A-Box, but so much more! Convention Meetings, Registration and Volunteers management software package
Apache License 2.0
9 stars 5 forks source link

Add endpoint to delete departments #675

Closed rkaiser-dev closed 7 months ago

rkaiser-dev commented 8 months ago

This PR adds an endpoint to Delete Departments/Divisions.

Currently there is no permission attached to this, but the original also lacked any sort of permission check on the back-end. I'm not super fond of this and would like to figure out a strategy for this going forward.

It also looks like maybe I need to include some deletes on EMails and EmailListAccess tables for this call as well, which is not currently implemented.

rkaiser-dev commented 7 months ago

I've added Email and EmailListAccess Service/Repository implementations since they are also needed here to fulfill the logic that was in use before.

I've updated DepartmentService to use these and DepartmentRepository to not actually delete the department.

This should be ready for another look.