CONP-PCNO / EEGNet-roadmap

EEGNet repository
MIT License
2 stars 0 forks source link

[Vis] Optimize loading for Signal plot #82

Open christinerogers opened 1 year ago

christinerogers commented 1 year ago

In an effort to show all channels, the default chunk size of channel data should be lowered. Additionally, the default time range when viewing a new recording should reflect this new smaller chunk size.

@Andesha @jeffersoncasimir

Andesha commented 1 year ago

Updated main card with more below.

Andesha commented 1 year ago

Signals are currently chunked such that you don't have to download all of the signal to see a given time chunk.

However, the default view of the signal plot shows the entire recording, forcing a download of everything despite the chunks.

By reducing chunk size and the default time window, the impact on a user's browser will be substantially lower and allow them to view more of the recording at one time.

christinerogers commented 1 year ago

@jeffersoncasimir Is this still a factor in favour of smaller chunks? We can discuss in today's WG meeting

Andesha commented 1 year ago

Perhaps worth pulling my branch with 18 channels selected and testing with the loris main bug fixes

christinerogers commented 1 year ago

less chunks might mean better performance, will investigate Nov. 24

Andesha commented 1 year ago

this can likely be closed as @jeffersoncasimir has tackled a bunch of things