search

COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
44 stars 15 forks source link

Remove some redundant variables and executions. #104

Closed cchrewrite closed 1 year ago

cchrewrite commented 1 year ago

Note: If you encounter failed tests when building the project by running "mvn clean package", please remove "cool-core/src/test/java/com/nus/cool/core/refactor", and try to build the project again. The failed tests already exist before this pull request.

cchrewrite commented 1 year ago

Note: If you encounter failed tests when building the project by running "mvn clean package", please remove "cool-core/src/test/java/com/nus/cool/core/refactor", and try to build the project again. The failed tests already exist before this pull request.

KimballCai commented 1 year ago

We have refactored the COOL system codes that is why we have a new folder "cool-core/src/test/java/com/nus/cool/core/refactor". Later, we will delete all other codes with the old version (e.g., Extendedxxxxx.java).

There may be some unit tests that will fail due to the version conflict, and we will remove these codes with the old version and clean all the unit tests.

KimballCai commented 1 year ago

In the refactored codes, it is easier for developers to understand the codes, and we also have updated many functions. e.g., support extending datasets, reducing redundancy storage, and so on.

cchrewrite commented 1 year ago

Sure. That will be very helpful!

KimballCai wrote: In the refactored codes, it is easier for developers to understand the codes, and we also have updated many functions. e.g., support extending datasets, reducing redundancy storage, and so on.

KimballCai commented 1 year ago

we will remove all the codes with the old version in the next two weeks.

Zrealshadow commented 1 year ago

Old-Version Code will be removed