search

COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
45 stars 16 forks source link

Refactor, use global_Id instead of raw value in Filter #105

Closed Zrealshadow closed 2 years ago

Zrealshadow commented 2 years ago

Can not pass MetaCubeTest. I have modified some interface of storage layer. Some functions of storage layer are outdated.

Zrealshadow commented 2 years ago

I have modified some interface in io layer. Maybe CubletSave function have to re-implement based on new interface. Then we can pass all unit test

Zrealshadow commented 2 years ago

disable two failed unittest

 dataChunkProceesTest(com.nus.cool.core.iceberg.query.IcebergSelectionTest)
 iceBergTest(com.nus.cool.functionality.IcebergLoaderTest)

@NLGithubWP will refactor iceBerg part. these two unittest for old version olap engine will be disabled temporarily

KimballCai commented 2 years ago

The code format has not been checked. Need to open another PR to format these codes.

hugy718 commented 2 years ago

There are so many files that have no meaningful changes but with their formats reverted back to codes before formatting. I just discussed with @Zrealshadow, and the plan is to open a new branch from dev, so that we all have write access to it. Open a new PR from that branch to dev. As we review the codes, we check if the diff is mere code formatting and use the dev branch files to replace their contents. @NLGithubWP @KimballCai

Zrealshadow commented 2 years ago

OK, refactor part is all formatted.