search

COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
45 stars 16 forks source link

Persistent cohort result format update #106

Closed NLGithubWP closed 2 years ago

NLGithubWP commented 2 years ago
  1. Store cohort-result by cohort name in the folder where the source cubelet file is stored.
  2. Add storing process into test file
Zrealshadow commented 2 years ago

? why closed @KimballCai

Zrealshadow commented 2 years ago

Solve the conflict to dev branch.

NLGithubWP commented 2 years ago

Please update the unit test case.

Updated

NLGithubWP commented 2 years ago

Conflicts solved; this PR is ready to merge; plz check again. @KimballCai

NLGithubWP commented 2 years ago

Store cohort results in the following folder. @KimballCai image

NLGithubWP commented 2 years ago

The CohortRS/WS impl is superceded by the CohortRSStr/WSStr, so they should be removed. CoolModel still uses CohortRS. Just remove those codes.

Should we remove it now? it may be used somewhere else later.

hugy718 commented 2 years ago

The CohortRS/WS impl is superceded by the CohortRSStr/WSStr, so they should be removed. CoolModel still uses CohortRS. Just remove those codes.

Should we remove it now? it may be used somewhere else later.

Just remove, it will otherwise confuse us in the future.

NLGithubWP commented 2 years ago

Removed