search

COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
45 stars 16 forks source link

Birth event not used for age selection #119

Closed KimballCai closed 1 year ago

KimballCai commented 1 year ago

according to the current code logic, a user with only one record will never be classified into any cohort. Please fix it.

Zrealshadow commented 1 year ago

please write a unit test for this corner case

hugy718 commented 1 year ago

I have looked into this problem and modified the Issue title to reflect the real problem.

Problem

The Cohort processor only process records of a user after she is born. The corner case is that birth event is not considered for age selection. This resulted in discrepancies for users that do not have subsequent records at the age 0 yet their birth event passes cohort selection