COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
45 stars 16 forks source link

query result cohort size is incorrect #141

Closed hugy718 closed 1 year ago

hugy718 commented 1 year ago

Problem

cohort size recorded in the query_res.json is inconsistent with the user list size stored in all.cohort. The issue is due to missing code in de-duplication in adding users during cohort processing.

https://github.com/COOL-cohort/COOL/blob/80070ff893b3101fe8c4f53f531ffc179e6026b3/cool-core/src/main/java/com/nus/cool/core/cohort/storage/CohortRet.java#L45-L50