search

COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
45 stars 16 forks source link

need to support float format in cohort results #154

Open KimballCai opened 1 week ago

KimballCai commented 1 week ago

please check the branch support_float_cohort_result

  1. update the unit test in the CohortAnalysisTest.java
  2. check the CohortRet.java incase there is any potential error left
tinyAdapter commented 1 week ago

I think the current implementation is problematic, as it breaks the original behavior and invalidates some tests.

I suggest adding a new entry in the cohort query file (e.g., resultType) with default value INT to make it backward-compatible, while allow users to specify the system to return float values.

tinyAdapter commented 1 week ago

Resolved in #155