search

COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
45 stars 16 forks source link

Fix time window effect on birth event selection range #25

Closed hugy718 closed 2 years ago

hugy718 commented 2 years ago

Fix #24

hugy718 commented 2 years ago

@KimballCai found another potential issue. In the same function. The birthOffset assignment on L485 does not match the comment. It is returned via cohort. Not sure if this is working as expected. I tried switching the condition to (birthoffset > offset) It only affected the query result in one result tuple ExtendedResultTuple(cohort=((1960, 1970]), age=0, measure=1594.0, min=0.0, max=85.0, sum=11888.0, num=381.0) by increasing the measure by 1. Others are the same.

KimballCai commented 2 years ago

Fix the issue #24 with the problem about the TimeWindow