COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
45 stars 16 forks source link

No explicit warining or exeception throwed when traverse the fields of dataChunk multipe times. #62

Open NLGithubWP opened 2 years ago

NLGithubWP commented 2 years ago

In the readStore, if we traverse one field multiple times, it reads the wrong value and does not throw expectations or warnings.

For example, in RLEInputVector readStore, if we traverse it multiple times with get, the end-offset will prevent the traverse and only return the value in the last offset, which results in a wrong read.

We should either explicitly throws exceptions to prevent multiple traverses, or allow it by removing such constraint or adding reset methods to reset the offset.

KimballCai commented 2 years ago

@NLGithubWP, please refer to this issue when you redesign the engine API