search

COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
44 stars 15 forks source link

test case for AvroDataLoaderConfig #70

Closed qlinsey closed 1 year ago

qlinsey commented 1 year ago
  1. update constructor of AvroDataLoaderConfig
  2. add test case for AvroDataLoaderConfig
KimballCai commented 1 year ago

Please make sure that the path of the test file should be started with java. e.g., /src/test/com/nus/cool/extension/util/arrow/ArrowRowViewTest.java is wrong. It should be /src/test/java/com/nus/cool/extension/util/arrow/ArrowRowViewTest.java

because maven compiling relies on this folder path.

hugy718 commented 1 year ago

Thank you for the contribution, we have tested after fixing the path and will merge this into dev. In the future, please rebase with respect to the latest dev branch head before submitting pull requests.

qlinsey commented 1 year ago

Please make sure that the path of the test file should be started with java. e.g., /src/test/com/nus/cool/extension/util/arrow/ArrowRowViewTest.java is wrong. It should be /src/test/java/com/nus/cool/extension/util/arrow/ArrowRowViewTest.java

because maven compiling relies on this folder path.

It seems this piece of code was merged. Next time will take care of the path. Thanks.

qlinsey commented 1 year ago

Thank you for the contribution, we have tested after fixing the path and will merge this into dev. In the future, please rebase with respect to the latest dev branch head before submitting pull requests.

Sure, thanks.