search

COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
45 stars 16 forks source link

IcebergQueryTest implicit dependencies on CsvLoaderTest #82

Closed hugy718 closed 1 year ago

hugy718 commented 2 years ago

EcommerceDataSetSQL1 test under IcebergQueryTest assumes that CsvLoaderTest to have loaded ecommerce data loaded in the cube repo. Yet this dependency unlike CohortSelectionTest/CohortAnalysisTest is not specified.

hugy718 commented 2 years ago

Maybe its better to reorganize the iceberg/query folder? Other functionality tests on loaded datasets are placed under functionality folder. @NLGithubWP

KimballCai commented 2 years ago

Need to modify the structure of these unit tests.

hugy718 commented 1 year ago

Now iceberg tests has been temporarily removed from dev. It will be fixed once porting is complete #138