search

COPRS / reference-system-software

This repository contains informations on the Reference System Software and how to contribute to the project.
Apache License 2.0
6 stars 5 forks source link

[FEATURE] GitGuardian advised implementation isn't in line with build constraints #28

Open fmorel-ads opened 3 years ago

fmorel-ads commented 3 years ago

Is your feature request related to a problem? Please describe. As stated in the reference-system repo, the advised implementation for GitGuardian is the following: https://github.com/COPRS/reference-system/blob/05f03134aee89e6b5ac7c3cec4ed886df3776a3b/.github/workflows/docker-ci.yaml#L33-L40

The use of the "default branch" (=main branch in our project) isn't in line with deployment that have to be done on the develop branch. It is for example the case in this build pipeline: image

Describe the solution you'd like We think that the advised GitGuardian implementation should be corrected

Describe alternatives you've considered See above

Additional context None

nleconte-csgroup commented 3 years ago

You may want to change the value of GITHUB_DEFAULT_BRANCH with the desired branch in your workflow : https://github.com/COPRS/production-common/blob/90c271d3abfeba20cdab84dffc2ad2aa558d82f1/.github/workflows/build-ci.yaml#L50

You could use the current branch like I just tested here : https://github.com/SANDBOX-COPRS/Examples/blob/86747fea255bd611342a952dc437b6eeaf01769f/.github/workflows/java-maven-ci.yaml#L48