[BUG][S3] Configuration mistakes on S3-SY2-AOD-NTC

eroan-marie commented 1 year ago

Environment:

Delivery tag: release/1.10.0
Platform: IVV Orange Cloud

Configuration: Default configuration

The execution worker doesn't start because its worker image is set to docker:artifactory.coprs.esa-copernicus.eu/rs-docker-private/rs-ipf-s3-sy2-aod-ntc:1.10.0-rc1 by default instead of docker:artifactory.coprs.esa-copernicus.eu/rs-docker-private/rs-ipf-s3-sy2-aod:1.10.0-rc1 The preparation worker and housekeep get in a crash loop (see error below). This is due to wrong parameters by default (see workaround)

Expected Behavior:

The application should be deployed and healthy

Steps To Reproduce:

In this environment...
With the default config
Deploy S3-SY2-AOD-NTC on version 1.10.0-rc1

See error...


{"header":{"type":"LOG","timestamp":"2023-02-07T09:05:59.865808Z","level":"ERROR","line":40,"file":"LoggingFailureAnalysisReporter.java","thread":"main"},"message":{"content":"

APPLICATION FAILED TO START

Description:

Failed to bind properties under 's3-type-adapter.mpcsearch.s3asy2aod' to esa.s1pdgs.cpoc.preparation.worker.config.type.S3TypeAdapterProperties$MPCSearchSettings:

Reason: org.springframework.core.convert.ConverterNotFoundException: No converter found capable of converting from type [java.lang.String] to type [esa.s1pdgs.cpoc.preparation.worker.config.type.S3TypeAdapterProperties$MPCSearchSettings]

Action:

Update your application's configuration"},"custom"{"logger_string":"org.springframework.boot.diagnostics.LoggingFailureAnalysisReporter"}}


**Workaround:**

Replacing the execution worker image for "docker:artifactory.coprs.esa-copernicus.eu/rs-docker-private/rs-ipf-s3-sy2-aod:1.10.0-rc1" in stream-application-list.properties
Replacing theses 4 lines in stream-parameters.properties :

app.preparation-worker.s3-type-adapter.mpcSearch.S3A_SY2_AOD=SL_1_RBT_ app.preparation-worker.s3-type-adapter.mpcSearch.S3B_SY2_AOD=SL_1RBT app.housekeep.s3-type-adapter.mpcSearch.S3A_SY2_AOD=SL_1_RBT_ app.housekeep.s3-type-adapter.mpcSearch.S3B_SY2_AOD=SL_1RBT

By :

app.preparation-worker.s3-type-adapter.mpcSearch.S3A_SY2_AOD.productTypes=SL_1_RBT_ app.preparation-worker.s3-type-adapter.mpcSearch.S3B_SY2_AOD.productTypes=SL_1RBT app.housekeep.s3-type-adapter.mpcSearch.S3A_SY2_AOD.productTypes=SL_1_RBT_ app.housekeep.s3-type-adapter.mpcSearch.S3B_SY2_AOD.productTypes=SL_1RBT



**Test execution artefacts (i.e. logs, screenshots…)**
Tip: You can attach images or log files by dragging & dropping, selecting or pasting them.

**Whenever possible, first analysis of the root cause**
<!-- A concise description of the first analysis. -->

 **Bug Generic Definition of Ready (DoR)**
- [X] The affect version in which the bug has been found is mentioned
- [X] The context and environment of the bug is detailed
- [X] The description of the bug is clear and unambiguous
- [X] The procedure (steps) to reproduce the bug is clearly detailed
- [ ] The failed tests is linked to the bug : failed result % expected result
- [ ] The tested User Story / features is linked to the bug
- [X] Logs are attached if available 
- [ ] A data set attached if available
- [X] Category label is link to the bug <!-- infra, mon, pro, perfo, hmi, secu -->

**Bug Generic Definition of Done (DoD)**
- [ ] the modification implemented (the solution to fix the bug) is described in the bug.
- [ ] Unit tests & Continuous integration performed  - Test results available - Structural Test coverage reported by SONAR
- [ ] Code committed in GIT with right tag or Analysis/Trade Off documentation up-to-date in reference-system-documentation repository
- [ ] Code is compliant with coding rules  (SONAR Report as evidence)
- [ ] Acceptance criteria of the related User story are checked and Passed