search

COPS-IITBHU / hackalog-backend

https://cops-hackalog.herokuapp.com/
5 stars 19 forks source link

Add Optimzing Search #47

Closed JeeveshGarg closed 3 years ago

JeeveshGarg commented 3 years ago

Fixes #39

king-11 commented 3 years ago

How is it different from the last one just wanted to know before reviewing... Also you should have made commits to the last PR only shouldn't have created multiple PRs for same thing.

JeeveshGarg commented 3 years ago

now i get to know difference between select_related and prefetch_related and your statement "Its for use cases when we will, later on, try to access a field"

About new PR, in earlier PR i got issues in env setup, their is correction in setup instruction in readme file ig, that why i setup project from scratch again.

king-11 commented 3 years ago

Cool I will try to give you a review by tomorrow or day after tomorrow thanks for taking up the issue 😄

king-11 commented 3 years ago

Hey @JeeveshGarg I think we can hasten up the process of reviewing if you can explain me your changes in a meet... So can you join the VC at 3PM Today?

JeeveshGarg commented 3 years ago

Okay.

JeeveshGarg commented 3 years ago

@king-11 PTAL, will make separate PR for issue #38 (with migration).

king-11 commented 3 years ago

@JeeveshGarg you still have to push in the migrations lemme know when you are done with that