search

COPS-IITBHU / hackalog-backend

https://cops-hackalog.herokuapp.com/
5 stars 19 forks source link

Added Hackathon endpoints #7

Closed aishwary023 closed 3 years ago

aishwary023 commented 3 years ago

Added:

aishwary023 commented 3 years ago

@nishantwrp Resolved conflicts, PTAL, thanks

nishantwrp commented 3 years ago

Oh wait, Make it GET /hackathons/id/teams/create then?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Aishwary Saxena notifications@github.com Sent: Tuesday, October 20, 2020 1:34:53 AM To: COPS-IITBHU/hackalog-backend hackalog-backend@noreply.github.com Cc: Nishant Mittal mittalnishant14@outlook.com; Mention mention@noreply.github.com Subject: Re: [COPS-IITBHU/hackalog-backend] Added Hackathon endpoints (#7)

@aishwary023 commented on this pull request.

In core/urls.pyhttps://github.com/COPS-IITBHU/hackalog-backend/pull/7#discussion_r508029249:

-urlpatterns = [ +urlpatterns = [

  • path('hackathons//teams/', HackathonTeamListView.as_view()),
  • path('hackathons/add-team/', HackathonTeamCreateView.as_view()),

@nishantwrphttps://github.com/nishantwrp There is no RetrieveCreateAPIView to apply post and get in a generic view. And the post() method does not expect a 'pk' keyword. Should I move this to POST /hackathons/teams/ or is there any other way?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/COPS-IITBHU/hackalog-backend/pull/7#discussion_r508029249, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI2GROAALT3NIPJDT6LOZ33SLSLWLANCNFSM4SUH3XOA.

aishwary023 commented 3 years ago

@nishantwrp Made the changes, PTAL

nishantwrp commented 3 years ago

Yup create another endpoint /hackathons/{id}/teams/join/{code}?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Aishwary Saxena notifications@github.com Sent: Monday, October 26, 2020 6:37:25 PM To: COPS-IITBHU/hackalog-backend hackalog-backend@noreply.github.com Cc: Nishant Mittal mittalnishant14@outlook.com; Mention mention@noreply.github.com Subject: Re: [COPS-IITBHU/hackalog-backend] Added Hackathon endpoints (#7)

@aishwary023 commented on this pull request.

In core/serializers.pyhttps://github.com/COPS-IITBHU/hackalog-backend/pull/7#discussion_r511944257:

  • model = Team
  • fields = 'all'

Ah, alright. So, initally when team is created, we would set the logged in user as the Leader and member. And set a TeamID, and register the team in the hackathon.

Now another user can enter TeamID to join the team. And for that we'll have to create another endpoint. Should I create that endpoint too or just proceed with the initial team creation?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/COPS-IITBHU/hackalog-backend/pull/7#discussion_r511944257, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI2GROBX6INXIIPSS6RPL73SMVYA3ANCNFSM4SUH3XOA.

aishwary023 commented 3 years ago

@nishantwrp ping