CORE-GATECH-GROUP / serpent-tools

A suite of parsers designed to make interacting with SERPENT output files simple and flawless
http://serpent-tools.readthedocs.io/en/latest/
MIT License
52 stars 33 forks source link

BUG Py 3.9 github action not working #466

Closed drewejohnson closed 1 year ago

drewejohnson commented 1 year ago

Summary of issue

See #465 test summary information. Py 3.9 hanging

Code for reproducing the issue

Actual outcome including console output and error traceback if applicable

Expected outcome

Versions

Please provide the following:

drewejohnson commented 1 year ago

py3.9 testing is not on develop branch. The confusion between develop and master is too confusing and should be cleaned up.

@DanKotlyar I think this project is in need of some repository structure updates. What do you think about the following changes

develop and master have diverged a lot. But, changes that have fixed various bugs are in master and have been / should be release

DanKotlyar commented 1 year ago

@drewejohnson I am ok with these changes.

drewejohnson commented 1 year ago

@DanKotlyar I just pushed a branch called main off of master. You can verify they are identical branches with

git switch master
git pull
git diff origin/main

The diff will print out no difference

But I don't have the ability to make it the default branch, nor the protected branch for this repository. It looks like you or someone else with write (maybe admin level) permissions to this repository will need to do

drewejohnson commented 1 year ago

@DanKotlyar ping on needing actions from you in order to make these changes

drewejohnson commented 1 year ago

@DanKotlyar I'm thinking about doing some serpent-tools updates over the next month or so. Having the changes from https://github.com/CORE-GATECH-GROUP/serpent-tools/issues/466#issuecomment-1279286356 incorporated would make development and deployment much easier. If you need anything from me please let me know. But I don't seem to have the permissions to make the changes on my own

DanKotlyar commented 1 year ago

Should I change permission settings?

drewejohnson commented 1 year ago

I don't think that's necessary just for this change. Here are the GitHub docs on changing the default branch for a repository - https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/changing-the-default-branch

DanKotlyar commented 1 year ago

I just changed the default branch to main. Any other changes I need to apply?

drewejohnson commented 1 year ago

That seems to have done the trick. Thanks @DanKotlyar!

drewejohnson commented 1 year ago

Working now as of https://github.com/CORE-GATECH-GROUP/serpent-tools/actions/runs/5220365753/job/14131376512