CORE-GATECH-GROUP / serpent-tools

A suite of parsers designed to make interacting with SERPENT output files simple and flawless
http://serpent-tools.readthedocs.io/en/latest/
MIT License
52 stars 33 forks source link

ENH ResultsReader supports Serpent 2.2.0 #472

Closed drewejohnson closed 1 year ago

drewejohnson commented 1 year ago

Closes #467

For bug fixes and enhancements, link to the corresponding issue.

Make sure you have read over the developer guide to ease the review process. These include:

Include a thorough and concise overview of the changes, and why this PR is overall beneficial to the project.

Once the PR has been created and is nearing closure, make sure that serious changes, including deprecations and incompatible changes are documented in the changelog

drewejohnson commented 1 year ago

@DanKotlyar and/or @aalfonsi can you check if the version string in the 2.2 result file is 2.2.0 or 2.2. I don't have the new version on my personal laptop to check

drewejohnson commented 1 year ago

Draft until #470

DanKotlyar commented 1 year ago

We don't have the new version yet so I don't know whether it is 2.2.0 or 2.2

aalfonsi commented 1 year ago

@DanKotlyar and/or @aalfonsi can you check if the version string in the 2.2 result file is 2.2.0 or 2.2. I don't have the new version on my personal laptop to check

2.2.0

aalfonsi commented 1 year ago

Screen Shot 2022-10-27 at 9 07 28 AM