CORE-GATECH-GROUP / serpent-tools

A suite of parsers designed to make interacting with SERPENT output files simple and flawless
http://serpent-tools.readthedocs.io/en/latest/
MIT License
52 stars 33 forks source link

[ENH] support Serepent 2.2.1 #481

Closed rzehumat closed 1 year ago

rzehumat commented 1 year ago

Closes #480

Make sure you have read over the developer guide to ease the review process. These include:

Include a thorough and concise overview of the changes, and why this PR is overall beneficial to the project.

Once the PR has been created and is nearing closure, make sure that serious changes, including deprecations and incompatible changes are documented in the changelog

rzehumat commented 1 year ago

Check MapStrVersions (tick if it's unchanged since 2.1.29)

rzehumat commented 1 year ago

Ok, I think it's ready for review, @drewejohnson

rzehumat commented 1 year ago

Now I'm unsure why I see "Changes requested" here. I thought your change request is resolved.

drewejohnson commented 1 year ago

Now I'm unsure why I see "Changes requested" here. I thought your change request is resolved.

It's just because the last review had changes requested. You applied them, and it looks great!