Closed rzehumat closed 1 year ago
Check MapStrVersions
(tick if it's unchanged since 2.1.29)
Ok, I think it's ready for review, @drewejohnson
2.2.1
to supported versions.
_res.m
file... If more testing is needed, let me know. Now I'm unsure why I see "Changes requested" here. I thought your change request is resolved.
Now I'm unsure why I see "Changes requested" here. I thought your change request is resolved.
It's just because the last review had changes requested. You applied them, and it looks great!
Closes #480
Make sure you have read over the developer guide to ease the review process. These include:
docs/contributors.rst
Include a thorough and concise overview of the changes, and why this PR is overall beneficial to the project.
Once the PR has been created and is nearing closure, make sure that serious changes, including deprecations and incompatible changes are documented in the changelog