search

CORE-GATECH-GROUP / serpent-tools

A suite of parsers designed to make interacting with SERPENT output files simple and flawless
http://serpent-tools.readthedocs.io/en/latest/
MIT License
52 stars 33 forks source link

[ENH] Sensitivity DataFrame #491

Open drewejohnson opened 1 year ago

drewejohnson commented 1 year ago

Re-applies changes from #483 by @GrimFe

GrimFe commented 1 year ago

Hi @drewejohnson,

Following up on what you proposed in my previous PR, I am going to PR to your branch (drewejohnson:drewj/reapply-sens-dataframe) with some test changes to fix my poor test implementation, which resulted in several tests not passing. This should keep tour full control on everything, if you have other preferred methodologies, please let me know.

It should now be fine concerning the test_sensitivity.py file; yet there is a not passing test related to the images produced by the plot method, I do not really see how my implementation would affect that, so it looks like I am missing something.

Do you have any idea how to fix this?

GrimFe commented 1 year ago

Hi @drewejohnson,

Following up on what you proposed in my previous PR, I am going to PR to your branch (drewejohnson:drewj/reapply-sens-dataframe) with some test changes to fix my poor test implementation, which resulted in several tests not passing. This should keep tour full control on everything, if you have other preferred methodologies, please let me know.

It should now be fine concerning the test_sensitivity.py file; yet there is a not passing test related to the images produced by the plot method, I do not really see how my implementation would affect that, so it looks like I am missing something.

Do you have any idea how to fix this?

Actually, I may not have the rights for this approach to the test fixing. Do you know more about this or can you please suggest a different way to edit the files?

Sorry for the inconvenience.