search

CORE-POS / IS4C

Cooperative Operational Retail Environment
http://www.core-pos.com
GNU General Public License v2.0
63 stars 44 forks source link

PaycardsTermCashBackLimit applied inconsistently #1023

Open joelbrock opened 5 years ago

joelbrock commented 5 years ago

In a couple places it appears that a cashback limit of $40 is hard-coded into the POS. Is this for a reason?

Here's where: https://github.com/CORE-POS/IS4C/blob/3405cf7435cc434d6dcadec807465a93d4cbe2ff/pos/is4c-nf/plugins/Paycards/gui/paycardboxMsgAuth.php#L79 https://github.com/CORE-POS/IS4C/blob/3405cf7435cc434d6dcadec807465a93d4cbe2ff/pos/is4c-nf/plugins/Paycards/gui/PaycardEmvPage.php#L72 https://github.com/CORE-POS/IS4C/blob/3405cf7435cc434d6dcadec807465a93d4cbe2ff/pos/is4c-nf/plugins/Paycards/gui/PaycardEmvPage.php#L78

gohanman commented 5 years ago

Presumably to limit cash back to $40

More seriously, from what I can see of the history there was a configurable limit back in version 1.2 (0c3772344dc9f48d9c21935ca31dcd09fcd67d1b). This would have been with the old Sign&Pays. I'm not sure why that didn't get carried forward; maybe the amounts available on the device screen were capped so having the cap on the PHP side didn't matter.

There probably should be a limit of some kind to prevent mistakes but using the configurable one makes way more sense than just hard-coding 40. 2c3f16cea2f5870e64152b572221c01f939060c6