search

CORE-POS / IS4C

Cooperative Operational Retail Environment
http://www.core-pos.com
GNU General Public License v2.0
63 stars 44 forks source link

Fix missing variable when trying to delete from ProductListPage #1098

Closed lgedgar closed 2 years ago

lgedgar commented 2 years ago

Saw this one come up in the wild. When viewing the ProductListPage, and trying to delete an item, it wouldn't work b/c of missing variable error. This "fixes" although not clear to me that the value in question is actually used anywhere..

Also not entirely clear that it should be quite that easy to delete an item..! But assuming the convenience is a good thing for power users etc.

Anyway this does fix the warning I saw which was:

[2021-09-30 13:10:14] fannie.WARNING: Undefined variable: encoded_desc Line 244, /srv/corepos/upstream/fannie/IS4C/fannie/item/ProductListPage.php [] []
gohanman commented 2 years ago

Interesting. It does appear that encoded description isn't used at all anymore, although this "fix" is probably better since it doesn't create javascript caching issues.