search

CORE-POS / IS4C

Cooperative Operational Retail Environment
http://www.core-pos.com
GNU General Public License v2.0
63 stars 44 forks source link

Allow plugins to be symlinks #1101

Closed lgedgar closed 2 years ago

lgedgar commented 2 years ago

for my local dev i have GitStatus plugin symlinked into the "normal" location at fannie/modules/plugins2.0/GitStatus - i.e. instead of installing it via Composer, which of course would work but then my composer.lock file would be out of whack with upstream.

the plugin itself worked okay i think but did not appear on the Scheduled Tasks page. so with this tweak it does appear.

Not sure if there are any other implications, esp. since this change affects more than Office... Maybe also you have a different / better idea for how I can get what I want?

gohanman commented 2 years ago

Looks sensible to me. I believe the only reason to call realpath is to resolve relative paths, and this should preserve that while allowing the one relevant directory level to be a symlink.