search

CORE-POS / IS4C

Cooperative Operational Retail Environment
http://www.core-pos.com
GNU General Public License v2.0
64 stars 44 forks source link

Lower log level for "nothing on sale" scenario #1104

Closed lgedgar closed 2 years ago

lgedgar commented 3 years ago

call it a nitpick but i don't want email about this..but do want email for "warning" level

gohanman commented 3 years ago

I'm skeptical this is a good idea. In a real world scenario this is a strong indication something has gone wrong, and if so it's also the kind of problem that will need attention quickly because it will impact customers.

lgedgar commented 3 years ago

Makes sense, although I'm seeing this email every night for a client - i.e. not in dev. Seems like it's "normal" for them and not a concern.

Maybe can add a setting? I often log different levels in rattail based on setting or other "context" - for example here and here.

I could see a simple setting being useful here, e.g. "NOTHING_ON_SALE_IS_OKAY" or whatever. Doubt it'd be important enough to expose in the admin UI but manually setting it could stop the nightly emails for them. Happy to implement but want to make sure we're on the right track first.

gohanman commented 3 years ago

That's probably the correct fix, although my inclination would be to touch base with the client. I've never been in a grocery store that has literally no promotional pricing happening, so it makes me wonder if they're manually adjusting prices up and down rather than scheduling the promo in advance and might benefit from being looped in on a different workflow.

lgedgar commented 2 years ago

Thanks, it seems you're probably right about that. Nevermind on this one.