search

CORE-POS / IS4C

Cooperative Operational Retail Environment
http://www.core-pos.com
GNU General Public License v2.0
63 stars 44 forks source link

Auto-focus for member search list at POS #1144

Closed lgedgar closed 2 years ago

lgedgar commented 2 years ago

This commit seems to have changed behavior for auto-focus of <select> element for member search results. Previously the list was auto-focused, but no longer.

Wasn't sure if that was intentional or just an accident given the nature of that commit. As you can see it now auto-focuses #reginput in all cases.

While troubleshooting this I also found that in BasicCorePage->commonHeader() it always auto-focuses #reginput - so was wondering if the memlist.php should do that? It appears to me that memlist.php could auto-focus #search but only if there were results, otherwise don't bother auto-focus anything since BasicCorePage would handle it.

gohanman commented 2 years ago

I think the breakage was here: 52cb01d0a27fec2cb2dbe65eb45083bdd777bd77

A 2nd id attribute gets added onto the <select> and screws things up - although I did check the 2.11 branch and it does not contain this commit.

lgedgar commented 2 years ago

Thanks - that did the trick.

I guess the code was more based on master than version-2.11..