module: _replaceModule uses send() method to transfer balance

[gundas]

If any of the future modules decide to implement a fallback function, the balance transfer to those modules might fail - send executes the fallback function on the destination contract, but the gas is limited to 2300: https://github.com/CORIONplatform/solidity/blob/master/module.sol#L99

As explained in http://www.blunderingcode.com/writing-secure-solidity/, a possible solution could be using:

 require( newModuleAddress.call.value(this.balance)() );

[iFA88]

I think the gas is not limited to 2300. Where you got that? send or call would do the same OP code.

[Dexaran]

This is critical: https://github.com/CORIONplatform/solidity/blob/master/module.sol#L98-L100

If there will be no function() payable { } in any future module then the replacement will fail!

Each module must have fallback function implementation by default.

[Dexaran]

@iFA88 .send provides 2300 gas. It's true.

The similar example is described here: http://solidity.readthedocs.io/en/develop/common-patterns.html

[iFA88]

https://github.com/CORIONplatform/solidity/pull/106