search

CORIONplatform / solidity

GNU General Public License v3.0
12 stars 9 forks source link

ICO will fail to receive ether if it is sent by a contract using send() #102

Closed gundas closed 7 years ago

gundas commented 7 years ago

Maybe it is non-issue, but the callback function in ICO contract https://github.com/CORIONplatform/solidity/blob/master/ico.sol#L288-L295 would consume more than 2300 gas. So any ether send() from another contract will fail.

http://solidity.readthedocs.io/en/develop/contracts.html#fallback-function

iFA88 commented 7 years ago

If a normal address or a contract calls the fallback function, it need specific gas. This GAS limit is declared who sends the transaction. I think 300k gas is safe for this function!