search

CORIONplatform / solidity

GNU General Public License v3.0
12 stars 9 forks source link

ICO set etcusd rate delay #109

Closed Dexaran closed 7 years ago

Dexaran commented 7 years ago

https://github.com/CORIONplatform/solidity/blob/master/ico.sol#L196-L209

I don't see any reasons of having this requirement. If you will set the price rate manually then in case of a mistake there will be wrong pricerate for next 720 blocks.

Why did you limited the opportunity to change price rate at any moment of time?

If you think that this is a question of trust then it doesn't solved it. The user should still trust that you will not make a mistake when changing price. Even more if you make an error you can not fix it for 720 blocks.

iFA88 commented 7 years ago

We know about that, thank for your feedback. It is ok for us.