No way to to change exchange address in the Token contract

gundas commented 7 years ago

I have a few issues/questions in regards to an exchange address stored in the Token contract:

will there always be only one exchange contract?
maybe it would be good to be able to change the exchange contract address without replacing the Token contract?
maybe (that is a bigger change) it would be good to separate transaction fee calculation to another contract? Then the Token need not even know the exchange addresses - it would only need to know the Fee Calculation contract.
- Or maybe exchange addresses could be retrieved from module handler?

iFA88 commented 7 years ago

We have discussed that. The first plan was that the users who buying ether only for gas ( above 0.2ETC ) we don't charge any fee. But I will now remove hard coded exchangeAddress for that.

Dexaran commented 7 years ago

I agree. The central controlling unit of the system is moduleHandler. It would be better to receive exchange address from moduleHandler contract.

CORIONplatform / solidity

No way to to change exchange address in the Token contract #118